Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate the Toolpad router from Toolpad server #2735

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 28, 2023

Next step in allowing users to attach Toolpad to an existing node http server

  • Isolate the Toolpad router
  • Run the websocket server on its own port (necessary because the router doesn't necessarily have access to the server it is running on)
  • Avoid running the websocket server in production
  • moving bashResolvePath to @mui/toolpad-utils/cli. @mui/toolpad-utils/path is used in the browser, it shouldn't import os or path. (a vite warning I noticed while working on this)

To do in follow up PRs:

  • basePath support. People want to run this as part of their own servers. Therefore we need to allow attaching the router under a basePath
  • allow optional reuse of httpServer for the websocket (need basePath support first for correct namespacing)
  • expose function publicly
  • documentation

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Sep 28, 2023
@Janpot Janpot marked this pull request as ready for review September 28, 2023 11:19
@Janpot Janpot requested a review from a team September 28, 2023 11:19
@Janpot Janpot changed the title Isolate the Toolpad router Isolate the Toolpad router from Toolpad server Sep 28, 2023
@Janpot Janpot merged commit 8644cc3 into mui:master Sep 28, 2023
11 checks passed
@Janpot Janpot deleted the ws-server branch September 28, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants